Fix landmark alignment case sensitivity and improve visualization (#84)#132
Open
Fix landmark alignment case sensitivity and improve visualization (#84)#132
Conversation
- Add normalize_landmarks_labels() for case-insensitive landmark mapping - Support common naming conventions (nasion, left ear, vertex, etc.) - Enhance plot_montage3D with landmarks parameter - Fix PointType enum comparison bug - Change default to show all 5 registration landmarks - Add 12 comprehensive tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #84 by adding case-insensitive landmark name normalization and improving landmark visualization in 3D montage plots.
Changes
1. New Function:
normalize_landmarks_labelsLocation: landmarks.py
Maps alternative landmark names to canonical labels with case-insensitive matching:
Handles duplicates by keeping canonical labels and dropping alternatives.
2. Enhanced
plot_montage3DFunctionLocation: montage.py
New Parameter:
landmarks: list[str] | NoneNone(default): Shows all available canonical registration landmarks (Nz, Iz, LPA, RPA, Cz)list[str]: Shows specified landmarks only[]: Shows no landmarksFixes and Improvements:
3. Testing
Added 12 tests in test_landmarks.py:
All tests pass:
pytest tests/test_landmarks.py -v # 12 passed in 4.45s4. Documentation
Example
Fixes #84